impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3291. Pause monitor thread should check tcmalloc performance
Date Fri, 15 Apr 2016 21:46:51 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3291. Pause monitor thread should check tcmalloc performance
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2707/1/be/src/common/init.cc
File be/src/common/init.cc:

Line 167: MarkThreadIdle
> is there any performance consideration with doing this twice a second on a 
Todd, thanks for answering my question in person (pointing out that this is only marking that
this thread is idle and only affects this thread's state). 

But follow up question: we are assuming no other allocation happens on this thread, right?
Are you sure that's the case? Should we do the MarkThreadIdle() before the malloc instead
(are the side effects of MarkThreadIdle synchronous)?


-- 
To view, visit http://gerrit.cloudera.org:8080/2707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40516456dda9ea6cfce3f2074ab9a4b25087c4bd
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Todd Lipcon <todd@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message