impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3077: Enable runtime filters when PHJ spills
Date Fri, 15 Apr 2016 18:33:51 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3077: Enable runtime filters when PHJ spills
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2783/4/be/src/exec/partitioned-hash-join-node.cc
File be/src/exec/partitioned-hash-join-node.cc:

Line 676:       runtime_filters_enabled_ = false;
i think it's confusing to set this global state now since it kind of gives it two meanings.
 At first it means: do we want to build the filters.  And then at this point it means: do
we want to publish the filters.

How about we remove this field and instead define BuildRuntimeFilters() { FLAG_.. &&
not in subnode; }  That should be fine now since you replace with a constant in codegen.

and then here we can just pass a local boolean variable to PublishRuntimeFilters() to indicate
whether to pass the filter.

I still think a little bit of benchmarking would be good in the case of ShouldDisableFilter()
returns true to verify we aren't slowing things down (much).


-- 
To view, visit http://gerrit.cloudera.org:8080/2783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59a2d9ee03ccea6b674392584e4c7f272233571e
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message