impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] Build Kudu from source
Date Fri, 15 Apr 2016 17:58:12 GMT
Casey Ching has posted comments on this change.

Change subject: Build Kudu from source
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2679/7/source/kudu/build.sh
File source/kudu/build.sh:

Line 97: # The line below configures clang to fing gcc from the toolchain. Without this the
       :     # build will still work on some system but there will be strange crashes at runtime.
       :     # On other systems, such as default RHEL6, the build will fail because c++11
isn't
       :     # supported on the system gcc.
       :     sed -i -r "s:^(set\(IR_FLAGS):\1\n  --gcc-toolchain=$(dirname $(which $CXX))/..:"
\
       :         src/kudu/codegen/CMakeLists.txt
> That's pretty wacky, but I guess it works.
I think we should find a better solution. Some that come to mind are

1) Add a wrapper script around Kudu's clang++ so that --gcc-toolchain always gets called.
Something like

#!/bin/bash
exec <path to clang++> --gcc-toolchain "$@"

2) Have the Kudu build system accept a gcc root parameter

3) Have the Kudu build system allow the user to specify a clang++, then the toolchain will
use it's own clang++ and be sure that it is built so that the proper gcc is used by default.

Do you like any of those or have some other idea? I'm thinking either #1 or #3.


-- 
To view, visit http://gerrit.cloudera.org:8080/2679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ec8494fb4e765ec796b31212c811af34e8514bd
Gerrit-PatchSet: 7
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Adar Dembo <adar@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message