impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3292. Kudu scanner should not fail if KeepAlive request fails
Date Fri, 15 Apr 2016 08:20:23 GMT
Casey Ching has posted comments on this change.

Change subject: IMPALA-3292. Kudu scanner should not fail if KeepAlive request fails
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2708/1/be/src/exec/kudu-scan-node.cc
File be/src/exec/kudu-scan-node.cc:

Line 438:       scanner.KeepKuduScannerAlive();
> seems like this could be simplified by rewriting the loop:
The next patch should be a little simpler.


-- 
To view, visit http://gerrit.cloudera.org:8080/2708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10ad2cfde3e50a4486d03f8dd763faac2eb4926a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Todd Lipcon <todd@apache.org>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message