impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3245 / IMPALA-3305: Fix crash with global filters when NUM_NODES=1
Date Fri, 15 Apr 2016 00:44:32 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3245 / IMPALA-3305: Fix crash with global filters when NUM_NODES=1
......................................................................


Patch Set 2:

(2 comments)

One more bug-fix needed - computeHasLocalTarget() wasn't being called if the join was partitioned.
This was probably because there were so many return paths from createHashJoinFragment() that
it seemed a good idea to save the LOC required to add that logic after the fragment was completed
everywhere.

To address that, I moved the partition fragment-creation logic into its own method (since
createHJF() was ~200 lines already), so now we only have to compute filter locality in one
place.

http://gerrit.cloudera.org:8080/#/c/2721/2/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:

Line 414:   /// Sets `filter_routing_table_complete_` and prints the table to the profile
and log.
> nit: don't we typically prefer single quotes over backticks?
Done


http://gerrit.cloudera.org:8080/#/c/2721/2/fe/src/main/java/com/cloudera/impala/planner/RuntimeFilterGenerator.java
File fe/src/main/java/com/cloudera/impala/planner/RuntimeFilterGenerator.java:

Line 109:     // If true, the filter is produced by a broadcast join and is applied on a scan
which
> Maybe slightly rephrase to say
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b9a6bcc64ca6ec5fd51d63815cea25de866ef93
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message