impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] Fix LLVM linker bug
Date Thu, 14 Apr 2016 23:11:24 GMT
Michael Ho has posted comments on this change.

Change subject: Fix LLVM linker bug
......................................................................


Patch Set 3:

(2 comments)

I am not super familiar with the context on why the linker distinguishes between opaque and
non-opaque type to begin with but this change seems to make sense.

http://gerrit.cloudera.org:8080/#/c/2656/3//COMMIT_MSG
Commit Message:

Line 20: the first structurally
       : identical type.
Did you mean opaque or non-opaque type here ? If so, it would be great to provide more details.


Line 25: istinct 
distinct


-- 
To view, visit http://gerrit.cloudera.org:8080/2656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8aef7f79c8d905b267f5acc3392384b1b333e7d3
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message