impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harrison Sheinblatt (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3326: TestShowCreateTable switched to use unique_database
Date Thu, 14 Apr 2016 19:44:32 GMT
Hello Michael Brown,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2768

to look at the new patch set (#3).

Change subject: IMPALA-3326: TestShowCreateTable switched to use unique_database
......................................................................

IMPALA-3326: TestShowCreateTable switched to use unique_database

There were two tests that use the same database with common setup/
teardown methods. If they were to run in parallel and one finished
before the other, the database would be removed while a test is
running, causing it to fail. Likewise if one started after the
other began.

The fix uses the unique_database fixture in each test so the tests
will not interfere with each other.

Change-Id: I4855a3a6ff0cea9f6cb3f8433e8705762afefe7d
---
M tests/metadata/test_show_create_table.py
1 file changed, 27 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/68/2768/3
-- 
To view, visit http://gerrit.cloudera.org:8080/2768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4855a3a6ff0cea9f6cb3f8433e8705762afefe7d
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Harrison Sheinblatt <hs7@hotmail.com>
Gerrit-Reviewer: Harrison Sheinblatt <hs7@hotmail.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message