impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3350: Add some missing StringVal.is_null checks
Date Thu, 14 Apr 2016 03:07:12 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3350: Add some missing StringVal.is_null checks
......................................................................


Patch Set 1:

(3 comments)

Thanks for combing through this all. Before I go through them all, how did you decide on which
it was needed? Just so I can double check that it's in the places where we expect it to be,
and not in places where it's not needed.

http://gerrit.cloudera.org:8080/#/c/2786/1/be/src/exprs/aggregate-functions.cc
File be/src/exprs/aggregate-functions.cc:

Line 280:   if (UNLIKELY(src.is_null)) return DoubleVal::null();
Is it necessary here? I don't think the agg intermediate value should be NULL.


Line 397:   const DecimalAvgState* src_struct =
Why not check here if we're checking in other places (in general I'm not sure if we need the
checks in these avg functions that have a fixed-size intermediate value.


Line 1257:   DCHECK(!dst->is_null);
Why check in the update but not the merge?


-- 
To view, visit http://gerrit.cloudera.org:8080/2786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55777487fff15a521818e39b4f93a8a242770ec2
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message