impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Simplify control flow in AnalyticEvalNode::GetNext()
Date Wed, 13 Apr 2016 20:35:13 GMT
Hello Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2773

to look at the new patch set (#2).

Change subject: Simplify control flow in AnalyticEvalNode::GetNext()
......................................................................

Simplify control flow in AnalyticEvalNode::GetNext()

This is a follow-up to the IMPALA-2829 patch and changes the control
flow so that two paths are obviously mutually exclusive (rather than
mutually exclusive by virtual of a variable being set to NULL).

Change-Id: I9fb53712fa11899c3b3d3ce1abdba9626bad023b
---
M be/src/exec/analytic-eval-node.cc
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/73/2773/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9fb53712fa11899c3b3d3ce1abdba9626bad023b
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message