impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Juan Yu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3038: Add multistream gzip/bzip2 test coverage
Date Wed, 13 Apr 2016 05:17:13 GMT
Juan Yu has posted comments on this change.

Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage
......................................................................


Patch Set 13:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/2543/13/be/src/util/decompress-test.cc
File be/src/util/decompress-test.cc:

Line 187: Input is NULL or input_len is 0
> the code checks compressed_length, not 'input' nor 'input_len'.  should the
Done


Line 232: .
> let's explicitly say: "We should get expected_stream_end == false but with 
Done


Line 252: 8MB
> which constant does this correspond to? can we make the other constants der
This is STREAM_OUT_BUF_SIZE defined in decompress.cc. I can move it to codec.h to expose it.


Line 258: rand
> can the seed be specified at the command line (to reproduce failures)?
see L366, the seed is printed so we could reproduce failures.


Line 273: some space
> is the "some space" why we do the - RAW_INPUT_SIZE?  Or is the choice of RA
Yes, it's why we do - RAW_INPUT_SIZE. Done


Line 291: 16
> summarize how this is chosen.
Done


Line 292: 32
> and this
Done


Line 294: 2 * 26
> and this
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88
Gerrit-PatchSet: 13
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message