impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Make test_low_mem_limit_low_selectivity_scan faster
Date Tue, 12 Apr 2016 22:10:05 GMT
Hello Michael Brown,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2766

to look at the new patch set (#2).

Change subject: Make test_low_mem_limit_low_selectivity_scan faster
......................................................................

Make test_low_mem_limit_low_selectivity_scan faster

The took ~7 mins to run on my machine. It was spending about half its
time re-creating the same data set over and over. This may also help
with the test failures during continuous integration.

All that needed to be done was to change the setup/teardown from method
level to class level. This should have no affect on the test coverage.

Change-Id: Ic874a7e9c8305bef3e16df03a807493f069e9265
---
M tests/query_test/test_kudu.py
1 file changed, 29 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/66/2766/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2766
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic874a7e9c8305bef3e16df03a807493f069e9265
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message