impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] Add TPC-H and TPC-DS
Date Tue, 12 Apr 2016 20:10:45 GMT
Casey Ching has posted comments on this change.

Change subject: Add TPC-H and TPC-DS
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2719/4/source/tpc-h/build.sh
File source/tpc-h/build.sh:

Line 29: TCP
> tpc
Done


Line 32:   # be done for all versions and the toolchain patch system isn't setup for that.
The
> How do you mean all versions? How often does the tpch version change? Copyi
All versions as in it seems like this will always need to be done.

It's not really a patch anyhow it's just how they expect people to build. They expect people
to manually edit the make file. It'll be strange to call that a patched version of TPC-H.


Line 72:     chmod +x "$LOCAL_INSTALL"/bin/dbgen
> Indentation seems off
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf16c7979b5d0456c7b4c0c1bdf4a75853922f7
Gerrit-PatchSet: 4
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message