impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Add NumFunctions and NumInstructions counters to LlvmCodeGen
Date Mon, 11 Apr 2016 21:41:08 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: Add NumFunctions and NumInstructions counters to LlvmCodeGen
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2756/1/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

Line 735:   // Update counters before final optimization
> Expand comment to explain why we're doing this after DCE
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a7f4aa02239d0738d891b09fa4531b560428898
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message