impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3302: Fix ASAN use-after-free failure in Kudu scanner
Date Mon, 11 Apr 2016 21:22:22 GMT
Hello Alex Behm,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2749

to look at the new patch set (#3).

Change subject: IMPALA-3302: Fix ASAN use-after-free failure in Kudu scanner
......................................................................

IMPALA-3302: Fix ASAN use-after-free failure in Kudu scanner

When fetching VARCHAR data from Kudu, Impala was using a pointer that
was owned and freed by the Kudu client. There was already a mechanism to
copy string data but it was only applied to STRING columns. The fix is
to apply the same mechanism to VARCHAR columns. That's done by adding
the VARCHAR column to the list of string type columns/slots that need to
be copied.

Change-Id: Ib513aae531086355e77ac9c35ed38728efaa0be9
---
M be/src/exec/kudu-scanner.cc
1 file changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/49/2749/3
-- 
To view, visit http://gerrit.cloudera.org:8080/2749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib513aae531086355e77ac9c35ed38728efaa0be9
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>

Mime
View raw message