impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3302: Fix ASAN use-after-free failure in Kudu scanner
Date Mon, 11 Apr 2016 21:18:59 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3302: Fix ASAN use-after-free failure in Kudu scanner
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2749/2/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

Line 91: IsVarLenStringType
no, your old code here was correct. i'm saying just change the dcheck below.


-- 
To view, visit http://gerrit.cloudera.org:8080/2749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib513aae531086355e77ac9c35ed38728efaa0be9
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message