impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Add -release switch to buildall.sh help, change coverage options.
Date Mon, 11 Apr 2016 19:48:32 GMT
Alex Behm has posted comments on this change.

Change subject: Add -release switch to buildall.sh help, change coverage options.
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/2043/5/buildall.sh
File buildall.sh:

Line 95:       TARGET_BUILD_TYPE=Release
We should consider renaming TARGET_BUILD_TYPE to CMAKE_BUILD_TYPE because that's what it really
is.


Line 100:     -codecoverage_debug)
Can we remove these for simplicity?


Line 203: # Set correct TARGET_BUILD_TYPE.
Maybe "Adjust CMAKE_BUILD_TYPE for ASAN and code coverage, if necessary."


Line 212:     *)
I think we can remove this or alternatively check the CMAKE_BUILD_TYPE outside of this case,
since it's not really related specifically to coverage.


Line 218: if [[ ${BUILD_ASAN} -eq 1 ]]; then
Also add a check for BUILD_ASAN=1 and BUILD_COVERAGE=1 which we don't support.


-- 
To view, visit http://gerrit.cloudera.org:8080/2043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id69791264cb2d9e0ffe96a7ac5aabc34a553a7be
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message