impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Juan Yu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2076: Correct execution time for DataStreamSender.
Date Fri, 08 Apr 2016 23:06:37 GMT
Juan Yu has posted comments on this change.

Change subject: IMPALA-2076: Correct execution time for DataStreamSender.
......................................................................


Patch Set 2:

@Henry, Thanks for reviewing and suggestion. I'll think about adding a new counter type for
the acquire / release semantics from UpdateSenderStats() and try to get rid of the new DoRpc....
We only want to count the send_TransmitData() timing because that's the main job of DataStreamSender
and that's where the network traffic spend. the recv_TransmitData() is mainly to wait for
receiver to deserialize data and process data, not using much network, plus those part are
already tracked by Exchange node. I'll update commit message with more details.

-- 
To view, visit http://gerrit.cloudera.org:8080/2578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c530b2056d852c8bcac6263e9e6b1a6bede1047
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message