impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3105: avoid overrunning allocated tuple buffer
Date Fri, 08 Apr 2016 20:23:19 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer
......................................................................


Patch Set 3:

BufferedTupleStream::GetRows() and PartitionedAggregationNode::ProcessBatchStreaming() are
two examples that depend on the invariant that the batch's initial capacity matching the constructor
argument. There may be more.

I'll look at the other points.

-- 
To view, visit http://gerrit.cloudera.org:8080/2473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfd9cd681875821c1c379d97586d3f4850aae622
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message