impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "anujphadke (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem
Date Thu, 07 Apr 2016 22:28:18 GMT
anujphadke has posted comments on this change.

Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1121/12/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

Line 419: configured_defaultFs=config_response.value;
> Don't we need to check config_response.__isset_value before accessing it?
What should be the default value if its not set?
Henry/Dan - Can we default it to hdfs:// ?


-- 
To view, visit http://gerrit.cloudera.org:8080/1121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed
Gerrit-PatchSet: 12
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message