impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost
Date Thu, 07 Apr 2016 20:41:51 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-2805: Order filters based on selectivity and cost
......................................................................


Patch Set 6:

Results for the targeted-perf test I added from a local run:

Report Generated on 2016-04-07

Cluster Name: UNKNOWN
Lab Run Info: UNKNOWN
Impala Version:          impalad version 2.6.0-cdh5-INTERNAL DEBUG (2016-03-11)
Baseline Impala Version: impalad version 2.6.0-cdh5-INTERNAL DEBUG (2016-03-11)

 +-----------------+---------------------+---------+------------+------------+----------------+
 | Workload        | File Format         | Avg (s) | Delta(Avg) | GeoMean(s) | Delta(GeoMean)
|
 +-----------------+---------------------+---------+------------+------------+----------------+
 | TARGETED-PERF() | text / none / none  | 3.81    | -52.11%    | 3.81       | -52.11%   
    |
 | TARGETED-PERF() | seq / gzip / block  | 0.21    | -92.86%    | 0.21       | -92.86%   
    |
 | TARGETED-PERF() | avro / snap / block | 0.21    | -92.99%    | 0.21       | -92.99%   
    |
 | TARGETED-PERF() | seq / snap / block  | 0.21    | -93.10%    | 0.21       | -93.10%   
    |
 | TARGETED-PERF() | avro / none / none  | 0.16    | -94.60%    | 0.16       | -94.60%   
    |
 | TARGETED-PERF() | rc / none / none    | 0.17    | -94.66%    | 0.17       | -94.66%   
    |
 +-----------------+---------------------+---------+------------+------------+----------------+

 +-----------------+-------------------+----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+
 | Workload        | Query             | File Format          | Avg(s) | Base Avg(s) | Delta(Avg)
| StdDev(%) | Base StdDev(%) | Num Clients | Iters |
 +-----------------+-------------------+----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+
 | TARGETED-PERF() | conjunct_ordering | text / none / none   | 3.81   | 7.96        | I -52.11%
 |   0.00%   |   0.00%        | 1           | 2     |
 | TARGETED-PERF() | conjunct_ordering | seq / block / block  | 0.21   | 2.99        | I -92.86%
 |   0.00%   |   0.00%        | 1           | 2     |
 | TARGETED-PERF() | conjunct_ordering | avro / block / block | 0.21   | 3.04        | I -92.99%
 |   0.00%   |   0.00%        | 1           | 2     |
 | TARGETED-PERF() | conjunct_ordering | seq / block / block  | 0.21   | 3.11        | I -93.10%
 |   0.00%   |   0.00%        | 1           | 2     |
 | TARGETED-PERF() | conjunct_ordering | avro / none / none   | 0.16   | 3.03        | I -94.60%
 |   0.00%   |   0.00%        | 1           | 2     |
 | TARGETED-PERF() | conjunct_ordering | rc / none / none     | 0.17   | 3.14        | I -94.66%
 |   0.00%   |   0.00%        | 1           | 2     |
 +-----------------+-------------------+----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+

 (I) Improvement: TARGETED-PERF() conjunct_ordering [text / none / none] (7.96s -> 3.81s
[-52.11%])
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | Operator     | % of Query | Avg      | Base Avg | Delta(Avg) | StdDev(%) | Max      | Base
Max | Delta(Max) | #Hosts | #Rows | Est #Rows |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | 00:SCAN HDFS | 99.99%     | 161.75ms | 2.95s    | -94.52%    |   0.00%   | 184.39ms | 3.06s
   | -93.98%    | 3      | 0     | 1         |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+

 (I) Improvement: TARGETED-PERF() conjunct_ordering [seq / gzip / block] (2.99s -> 0.21s
[-92.86%])
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | Operator     | % of Query | Avg      | Base Avg | Delta(Avg) | StdDev(%) | Max      | Base
Max | Delta(Max) | #Hosts | #Rows | Est #Rows |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | 00:SCAN HDFS | 99.99%     | 158.21ms | 2.91s    | -94.57%    |   0.00%   | 183.02ms | 2.95s
   | -93.79%    | 3      | 0     | 1         |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+

 (I) Improvement: TARGETED-PERF() conjunct_ordering [avro / snap / block] (3.04s -> 0.21s
[-92.99%])
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | Operator     | % of Query | Avg      | Base Avg | Delta(Avg) | StdDev(%) | Max      | Base
Max | Delta(Max) | #Hosts | #Rows | Est #Rows |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | 00:SCAN HDFS | 99.99%     | 154.99ms | 2.80s    | -94.46%    |   0.00%   | 180.54ms | 3.01s
   | -94.00%    | 3      | 0     | 1         |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+

 (I) Improvement: TARGETED-PERF() conjunct_ordering [seq / snap / block] (3.11s -> 0.21s
[-93.10%])
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | Operator     | % of Query | Avg      | Base Avg | Delta(Avg) | StdDev(%) | Max      | Base
Max | Delta(Max) | #Hosts | #Rows | Est #Rows |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | 00:SCAN HDFS | 99.99%     | 146.72ms | 2.94s    | -95.01%    |   0.00%   | 161.85ms | 3.06s
   | -94.71%    | 3      | 0     | 1         |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+

 (I) Improvement: TARGETED-PERF() conjunct_ordering [avro / none / none] (3.03s -> 0.16s
[-94.60%])
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | Operator     | % of Query | Avg      | Base Avg | Delta(Avg) | StdDev(%) | Max      | Base
Max | Delta(Max) | #Hosts | #Rows | Est #Rows |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | 00:SCAN HDFS | 99.99%     | 120.49ms | 2.95s    | -95.91%    |   0.00%   | 127.66ms | 3.00s
   | -95.74%    | 3      | 0     | 1         |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+

 (I) Improvement: TARGETED-PERF() conjunct_ordering [rc / none / none] (3.14s -> 0.17s
[-94.66%])
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | Operator     | % of Query | Avg      | Base Avg | Delta(Avg) | StdDev(%) | Max      | Base
Max | Delta(Max) | #Hosts | #Rows | Est #Rows |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+
 | 00:SCAN HDFS | 99.99%     | 127.85ms | 2.93s    | -95.64%    |   0.00%   | 136.89ms | 3.08s
   | -95.55%    | 3      | 0     | 1         |
 +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+-----------+

Significant perf change detected

-- 
To view, visit http://gerrit.cloudera.org:8080/2598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02279a26fbc6308ac5eb819d78345fc010469034
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message