impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3148. Fix selectivity computation for pushed Kudu predicates
Date Wed, 06 Apr 2016 06:42:01 GMT
Casey Ching has uploaded a new patch set (#3).

Change subject: IMPALA-3148. Fix selectivity computation for pushed Kudu predicates
......................................................................

IMPALA-3148. Fix selectivity computation for pushed Kudu predicates

This follows up on a TODO from the Kudu merge and also fixes a bug:
IMPALA-976 changed the computation of selectivities for a combined
list of conjuncts to better handle expressions with no selectivity
estimate. The Kudu implementation was forked from before this change
and thus did not have an equivalent change.

This refactors the algorithm to a new static method and calls it from
both PlanNode and KuduScanNode so that the selectivity estimate
behavior is the same regardless of whether Kudu can evaluate the
predicate server-side.

Todd tested this on TPCH 3TB and verified that the plans are reasonable
now where they used to be nonsense.

Change-Id: Id507077b577ed5804fc80517f33ea185f2bff41a
---
M fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java
M fe/src/main/java/com/cloudera/impala/planner/PlanNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test
3 files changed, 80 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/28/2628/3
-- 
To view, visit http://gerrit.cloudera.org:8080/2628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id507077b577ed5804fc80517f33ea185f2bff41a
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Todd Lipcon <todd@apache.org>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>

Mime
View raw message