impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2198: Differentiate queries in exceptional states in web UI
Date Tue, 05 Apr 2016 18:52:53 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2625/1/www/queries.tmpl
File www/queries.tmpl:

Line 60:   {{num_waiting_queries}} waiting on client
> waiting to be closed is better than waiting on client, so go ahead with tha
Done


Line 61:   <sup><a href='#' data-toggle="tooltip" title="{{waiting-tooltip}}">[?]</a></sup>
> Not sure, and it seems hard to Google. Leave it like this for now and we'll
Done


Line 77:     <th>Action</th>
> The last time the client contacted the server for this query is probably ok
It looks like last_active_time is updated either when a query first gets executed or when
a fetch is performed, so that's close to "the last time the client contacted the server for
this query", but not quite the same thing, eg. we don't record the time when a client calls
Cancel or GetStatus on an operation.


-- 
To view, visit http://gerrit.cloudera.org:8080/2625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message