impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3038: Add multistream gzip/bzip2 test coverage
Date Tue, 05 Apr 2016 18:00:25 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2543/10/be/src/util/decompress.cc
File be/src/util/decompress.cc:

Line 95:   *stream_end = input_length == 0;
Are you sure this is always correct thing to do given the way HdfsTextScanner::DecompressBufferStream()
uses this routine.  (In terms of wanting to retry if progress was not made and also for finding
malformed files -- e.g. ones without Z_STREAM_END).

Why was this added?


-- 
To view, visit http://gerrit.cloudera.org:8080/2543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88
Gerrit-PatchSet: 10
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message