Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7D95E19BE2 for ; Mon, 28 Mar 2016 20:19:47 +0000 (UTC) Received: (qmail 90596 invoked by uid 500); 28 Mar 2016 20:19:47 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 90557 invoked by uid 500); 28 Mar 2016 20:19:47 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 90546 invoked by uid 99); 28 Mar 2016 20:19:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Mar 2016 20:19:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id ABC4EC0D22 for ; Mon, 28 Mar 2016 20:19:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id VaPE025Cp5yj for ; Mon, 28 Mar 2016 20:19:45 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B27E35F238 for ; Mon, 28 Mar 2016 20:19:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u2SKJhP7020494; Mon, 28 Mar 2016 20:19:43 GMT Message-Id: <201603282019.u2SKJhP7020494@ip-10-146-233-104.ec2.internal> Date: Mon, 28 Mar 2016 20:19:43 +0000 From: "Internal Jenkins (Code Review)" To: Dan Hecht , impala-cr@cloudera.com, dev@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3243:_Delete_unneeded_code_that_doesn't_work_on_RHEL_5=0A?= X-Gerrit-Change-Id: I82b71de60e5bf8abec18f981d13528991265908f X-Gerrit-ChangeURL: X-Gerrit-Commit: daddb27578027bdb565652c5e0d9ab823a324890 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3243: Delete unneeded code that doesn't work on RHEL 5 ...................................................................... IMPALA-3243: Delete unneeded code that doesn't work on RHEL 5 The MaxCPUIndex() interface was added by Kudu, but the code that initializes it doesn't work on RHEL 5. Impala doesn't depend on MaxCpuIndex() at all, but the value is calculated and cached at startup time so it still executes. So, let's just delete this effectively dead code that doesn't work on RHEL 5. Change-Id: I82b71de60e5bf8abec18f981d13528991265908f Reviewed-on: http://gerrit.cloudera.org:8080/2626 Reviewed-by: Dan Hecht Tested-by: Internal Jenkins --- M be/src/gutil/sysinfo.cc M be/src/gutil/sysinfo.h 2 files changed, 0 insertions(+), 37 deletions(-) Approvals: Internal Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82b71de60e5bf8abec18f981d13528991265908f Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Internal Jenkins