Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EEC2D1997B for ; Thu, 24 Mar 2016 16:52:16 +0000 (UTC) Received: (qmail 48821 invoked by uid 500); 24 Mar 2016 16:52:16 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 48780 invoked by uid 500); 24 Mar 2016 16:52:16 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 48768 invoked by uid 99); 24 Mar 2016 16:52:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2016 16:52:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 44EEB180112 for ; Thu, 24 Mar 2016 16:52:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Y_IWEAtBZbQX for ; Thu, 24 Mar 2016 16:52:14 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 9794E5F119 for ; Thu, 24 Mar 2016 16:52:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u2OGqBlZ006692; Thu, 24 Mar 2016 16:52:11 GMT Message-Id: <201603241652.u2OGqBlZ006692@ip-10-146-233-104.ec2.internal> Date: Thu, 24 Mar 2016 16:52:11 +0000 From: "Skye Wanderman-Milne (Code Review)" To: Juan Yu , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: skye@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3038:_Add_multistream_gzip/bzip2_test_coverage=0A?= X-Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88 X-Gerrit-ChangeURL: X-Gerrit-Commit: 82dd307b45e8638e0af4d38635d68436939d99ff In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/2543/7/be/src/util/decompress-test.cc File be/src/util/decompress-test.cc: Line 255: // Repeatedly pick random-size input data(~1MB), compress it, then concatenate What does the ~1MB mean? I think this is why I got confused about L270 earlier, isn't the input data closer to 7-8MB? Line 266: EXPECT_OK(Codec::CreateCompressor(&mem_pool_, true, format, &compressor)); Move created compressor above comment -- To view, visit http://gerrit.cloudera.org:8080/2543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu Gerrit-Reviewer: Juan Yu Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-HasComments: Yes