Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C9B3518140 for ; Tue, 22 Mar 2016 01:14:25 +0000 (UTC) Received: (qmail 66452 invoked by uid 500); 22 Mar 2016 01:14:25 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 66385 invoked by uid 500); 22 Mar 2016 01:14:25 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 66204 invoked by uid 99); 22 Mar 2016 01:14:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 01:14:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 08288C0F45 for ; Tue, 22 Mar 2016 01:14:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id T01dZHJKmJBc for ; Tue, 22 Mar 2016 01:14:24 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 53AB65F39A for ; Tue, 22 Mar 2016 01:14:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u2M1ENAB029975; Tue, 22 Mar 2016 01:14:23 GMT Message-Id: <201603220114.u2M1ENAB029975@ip-10-146-233-104.ec2.internal> Date: Tue, 22 Mar 2016 01:14:23 +0000 From: "Dan Hecht (Code Review)" To: Thomas Tauber-Marshall , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Matthew Jacobs Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3230:_Spurious_errors_from_DeleteOldLogs()=0A?= X-Gerrit-Change-Id: I485b7c97b01bf17ad75cf8a456b2e4fbce91d31d X-Gerrit-ChangeURL: X-Gerrit-Commit: c3bc102db57f479e095fcbd51242afcdac23d89c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Dan Hecht has posted comments on this change. Change subject: IMPALA-3230: Spurious errors from DeleteOldLogs() ...................................................................... Patch Set 2: (1 comment) Code change looks good to me but please respond to Matt's question about testing. http://gerrit.cloudera.org:8080/#/c/2596/2/be/src/util/logging-support.cc File be/src/util/logging-support.cc: Line 113: nit: this blank line doesn't help readability, delete it. -- To view, visit http://gerrit.cloudera.org:8080/2596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I485b7c97b01bf17ad75cf8a456b2e4fbce91d31d Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes