Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201603180028.u2I0S1u5012890@ip-10-146-233-104.ec2.internal>
Date: Fri, 18 Mar 2016 00:28:01 +0000
From: "Skye Wanderman-Milne (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, dev@impala.incubator.apache.org
CC: Michael Ho <kwho@cloudera.com>
Reply-To: skye@cloudera.com
Subject: 
 =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-2548:_Codegen_Tuple::MaterializeExprs()_and_use_in_TopN_node=0A?=
In-Reply-To: 
 <gerrit.1453770925000.Ib422a8d50303c21c6a228675157bf867e8619444@gerrit.cloudera.org>
References: 
 <gerrit.1453770925000.Ib422a8d50303c21c6a228675157bf867e8619444@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.10-rc0

Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node
......................................................................


Patch Set 8:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/1901/8/be/src/codegen/codegen-anyval.cc
File be/src/codegen/codegen-anyval.cc:

Line 585: WriteToSlot
> Have you considered refactoring the code so there is more sharing with Text
Hm, I'm not sure how to share code, but maybe you have some ideas? TextConverter::WriteSlot()/CodegenWriteSlot() are mostly dealing with parsing string input and don't deal with AnyVals at all, but I could be missing something.


Line 597:   // Create new block after conditional blocks if necessary
        :   if (insert_before == NULL) insert_before = BasicBlock::Create(context, "end_write", fn);
> Just wondering why this statement isn't before the creation of the two basi
BasicBlock::Create() will insert a block at the end of the function if 'insert_before' is NULL, so it doesn't matter where we create insert_before. I put it here so the blocks are created in the order they appear in the IR, but I can see how this is confusing so I'll move it above the "null"/"non_null" creation.


http://gerrit.cloudera.org:8080/#/c/1901/8/be/src/runtime/tuple.cc
File be/src/runtime/tuple.cc:

Line 331: >GetPtrType(
> Can you please update the patch to converge on using only one of GetPtrType
Ok. I was mixing these because I like Value::getPointerTo() better than codegen->GetPtrTo(Value*), but I like codegen->GetPtrTo(string type_name) better than codegen->GetPtrTo(type_name)->getPointerTo(). I'll just use GetPtrType() here though.


http://gerrit.cloudera.org:8080/#/c/1901/8/be/src/runtime/tuple.h
File be/src/runtime/tuple.h:

Line 148: MemPool* pool,
> Can we drop this parameter and update CodegenMaterializeExprs() to generate
Done


Line 164: MemPool* pool,
> Can we drop this parameter ?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/1901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib422a8d50303c21c6a228675157bf867e8619444
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes