Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AAE1E19249 for ; Thu, 17 Mar 2016 00:09:05 +0000 (UTC) Received: (qmail 93094 invoked by uid 500); 17 Mar 2016 00:09:05 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 93054 invoked by uid 500); 17 Mar 2016 00:09:05 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 93043 invoked by uid 99); 17 Mar 2016 00:09:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Mar 2016 00:09:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 02B82C03E9 for ; Thu, 17 Mar 2016 00:09:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id FtYvInb7xou4 for ; Thu, 17 Mar 2016 00:09:03 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 832C65F56B for ; Thu, 17 Mar 2016 00:09:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u2H091fM027315; Thu, 17 Mar 2016 00:09:01 GMT Message-Id: <201603170009.u2H091fM027315@ip-10-146-233-104.ec2.internal> Date: Thu, 17 Mar 2016 00:09:01 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht , Skye Wanderman-Milne Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Inject_precision_and_scale_constants_for_all_decimal_builtins=0A?= X-Gerrit-Change-Id: I7b7d1485f357ba88517ca15c5c7428c0ffe25dfd X-Gerrit-ChangeURL: X-Gerrit-Commit: a0794ec5c2d10b735deae7f852c2a9b19026f95a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Tim Armstrong has posted comments on this change. Change subject: Inject precision and scale constants for all decimal builtins ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/2535/6/be/src/exprs/expr.cc File be/src/exprs/expr.cc: Line 637: // Increment iter now so we don't mess it up modifying the instrunction below > Can you fix 'instrunction' while you're here? Done http://gerrit.cloudera.org:8080/#/c/2535/6/be/src/exprs/expr.h File be/src/exprs/expr.h: Line 276: // InlineConstants() must be run on the function to replace recognized constants. The > InlineConstants() doesn't have to be run, the interpreted path does not run Done Line 297: int InlineConstants(LlvmCodeGen* codegen, llvm::Function* fn); > Maybe keep this signature protected, since it's meant to be used by Expr su Done http://gerrit.cloudera.org:8080/#/c/2535/6/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: Line 486: InlineConstants(return_type, arg_types, codegen, *udf); > Use the original InlineConstants signature? Ah, forgot to fix this up. Done. -- To view, visit http://gerrit.cloudera.org:8080/2535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b7d1485f357ba88517ca15c5c7428c0ffe25dfd Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes