Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95E7219297 for ; Wed, 16 Mar 2016 00:18:26 +0000 (UTC) Received: (qmail 35693 invoked by uid 500); 16 Mar 2016 00:18:26 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 35654 invoked by uid 500); 16 Mar 2016 00:18:26 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 35643 invoked by uid 99); 16 Mar 2016 00:18:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Mar 2016 00:18:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E131AC0D64 for ; Wed, 16 Mar 2016 00:18:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id OAnASjB4o7uI for ; Wed, 16 Mar 2016 00:18:25 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 3B99C5FB2E for ; Wed, 16 Mar 2016 00:18:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u2G0IMQb012942; Wed, 16 Mar 2016 00:18:22 GMT Message-Id: <201603160018.u2G0IMQb012942@ip-10-146-233-104.ec2.internal> Date: Wed, 16 Mar 2016 00:18:22 +0000 From: "Dan Hecht (Code Review)" To: Anuj Phadke , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Henry Robinson , Juan Yu , Sailesh Mukil , Casey Ching Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-1850_allow_fs.defaultFS_to_be_set_to_a_non-HDFS_filesystem=0A?= X-Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed X-Gerrit-ChangeURL: X-Gerrit-Commit: d727925a345dc8ee1a6a20ffefe90bb0c3fc9dc1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Dan Hecht has posted comments on this change. Change subject: IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/1121/9/bin/impala-config.sh File bin/impala-config.sh: Line 103: export FILESYSTEM_PREFIX="s3a://${S3_BUCKET}" > To address Henry's comment (on this line in patch set 6), you can do the fo I don't think we should set FILESYSTEM_PREFIX if we're going to run S3 by setting defaultFS. The point of defaultFS is so you don't need to qualify the paths. -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Anuj Phadke Gerrit-Reviewer: Anuj Phadke Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Juan Yu Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes