Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 538A6188A7 for ; Tue, 15 Mar 2016 05:55:05 +0000 (UTC) Received: (qmail 68434 invoked by uid 500); 15 Mar 2016 05:55:05 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 68391 invoked by uid 500); 15 Mar 2016 05:55:05 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 68380 invoked by uid 99); 15 Mar 2016 05:55:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Mar 2016 05:55:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9B67B1A0234 for ; Tue, 15 Mar 2016 05:55:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id tmCjOXBtlsCM for ; Tue, 15 Mar 2016 05:55:03 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 31C6B5F2F2 for ; Tue, 15 Mar 2016 05:55:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u2F5t16o023724; Tue, 15 Mar 2016 05:55:01 GMT Message-Id: <201603150555.u2F5t16o023724@ip-10-146-233-104.ec2.internal> Date: Tue, 15 Mar 2016 05:55:01 +0000 From: "Casey Ching (Code Review)" To: David Ribeiro Alves , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht , Marcel Kornacker , Tim Armstrong Reply-To: casey@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Address_last_few_review_items_on_the_impala-kudu_merge=0A?= X-Gerrit-Change-Id: Ibc4b30180a8f23394c7afc32b32668b05f142eff X-Gerrit-ChangeURL: X-Gerrit-Commit: 5681bef9ae39a6230517985d2ae30f46d997fadd In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Casey Ching has posted comments on this change. Change subject: Address last few review items on the impala-kudu merge ...................................................................... Patch Set 2: Code-Review+1 Ok thanks for updating this stuff. I think the deploy script needs a bit more of an explanation about why it exits and when it can be removed. I'll add that later though. Needs a +2 from Dan or Marcel. -- To view, visit http://gerrit.cloudera.org:8080/2545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc4b30180a8f23394c7afc32b32668b05f142eff Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No