Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201603142320.u2ENKlEe011886@ip-10-146-233-104.ec2.internal>
Date: Mon, 14 Mar 2016 23:20:47 +0000
From: "Dan Hecht (Code Review)" <gerrit@cloudera.org>
To: Skye Wanderman-Milne <skye@cloudera.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: Silvius Rus <srus@cloudera.com>
Reply-To: dhecht@cloudera.com
Subject: 
 =?UTF-8?Q?[Impala-CR](cdh5-trunk)_PREVIEW_do_parquet_schema_resolution_by_name_instead_of_ordinal=0A?=
In-Reply-To: 
 <gerrit.1456882852000.Id0c715ea23792b2a6872610839a40532aabbb5a6@gerrit.cloudera.org>
References: 
 <gerrit.1456882852000.Id0c715ea23792b2a6872610839a40532aabbb5a6@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.10-rc0

Dan Hecht has posted comments on this change.

Change subject: PREVIEW do parquet schema resolution by name instead of ordinal
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/2384/1/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 193:       resolve_by_name_(state->query_options().resolve_parquet_by_name),
let's just use the query option directly rather than having more state to keep track of.


Line 1994:   if (resolve_by_name_ && (next_idx == 0 || col_type->type == TYPE_STRUCT)) {
why is it that arrays and maps don't also take this path?  a comment explaining this might help.

also, this logic and the one at L1945 now look kinda similar. i wonder if there's a way to refactor the code?


http://gerrit.cloudera.org:8080/#/c/2384/1/be/src/exec/hdfs-parquet-scanner.h
File be/src/exec/hdfs-parquet-scanner.h:

Line 425: resolve_by_name
query option


http://gerrit.cloudera.org:8080/#/c/2384/1/be/src/service/query-options.h
File be/src/service/query-options.h:

Line 77:   QUERY_OPT_FN(resolve_parquet_by_name, RESOLVE_PARQUET_BY_NAME);
how about making this an enum (i.e. position, name, and eventually field-id).


-- 
To view, visit http://gerrit.cloudera.org:8080/2384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0c715ea23792b2a6872610839a40532aabbb5a6
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Silvius Rus <srus@cloudera.com>
Gerrit-HasComments: Yes