Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A13EC18551 for ; Wed, 9 Mar 2016 18:28:14 +0000 (UTC) Received: (qmail 28517 invoked by uid 500); 9 Mar 2016 18:28:14 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 28475 invoked by uid 500); 9 Mar 2016 18:28:14 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 28464 invoked by uid 99); 9 Mar 2016 18:28:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Mar 2016 18:28:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E99FBC36A4 for ; Wed, 9 Mar 2016 18:28:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YWaPy0SK_dBS for ; Wed, 9 Mar 2016 18:28:13 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 1C4905FAD8 for ; Wed, 9 Mar 2016 18:28:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u29ISAWx028836; Wed, 9 Mar 2016 18:28:10 GMT Message-Id: <201603091828.u29ISAWx028836@ip-10-146-233-104.ec2.internal> Date: Wed, 9 Mar 2016 18:28:10 +0000 From: "Dan Hecht (Code Review)" To: David Ribeiro Alves , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Henry Robinson , Martin Grund , Alex Behm , Marcel Kornacker , Silvius Rus , Todd Lipcon , Tim Armstrong Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Review_Only:_Kudu_Impala_integration=0A?= X-Gerrit-Change-Id: I239314acbc8434ef673a3a59d2a82a0338ea5876 X-Gerrit-ChangeURL: X-Gerrit-Commit: 453e94d5355fbf907f40ab255bbff48e335a44ed In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Dan Hecht has posted comments on this change. Change subject: Review Only: Kudu Impala integration ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Backend still looks okay to me. http://gerrit.cloudera.org:8080/#/c/1403/7/be/src/scheduling/simple-scheduler.cc File be/src/scheduling/simple-scheduler.cc: Line 573: // TODO: KUDU-1133 Use the tablet size instead. Maybe this should be an IMPALA jira instead? -- To view, visit http://gerrit.cloudera.org:8080/1403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I239314acbc8434ef673a3a59d2a82a0338ea5876 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Martin Grund Gerrit-Reviewer: Silvius Rus Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes