Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201603080320.u283KuEj029143@ip-10-146-233-104.ec2.internal>
Date: Tue, 8 Mar 2016 03:20:47 +0000
From: "Casey Ching (Code Review)" <gerrit@cloudera.org>
To: Todd Lipcon <todd@apache.org>, Dan Hecht <dhecht@cloudera.com>,
        impala-cr@cloudera.com, dev@impala.incubator.apache.org
CC: David Ribeiro Alves <david.alves@cloudera.com>,
        Adar Dembo <adar@cloudera.com>
Reply-To: casey@cloudera.com
Subject: 
 =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Get_and_use_Kudu_from_the_toolchain_by_default=0A?=
In-Reply-To: 
 <gerrit.1454374088000.I3db88cbd27f2ea2394f011bc8d1face37411ed58@gerrit.cloudera.org>
References: 
 <gerrit.1454374088000.I3db88cbd27f2ea2394f011bc8d1face37411ed58@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.10-rc0

Hello Todd Lipcon, Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/1985

to look at the new patch set (#6).

Change subject: Get and use Kudu from the toolchain by default
......................................................................

Get and use Kudu from the toolchain by default

This is for review purposes only. This patch will be merged with David's
big merge patch.

Changes:
1) Make Kudu compilation dependent on the OS since not all OSs support
   Kudu.
2) Only run Kudu related tests when Kudu is supported (see #1).
3) Look for Kudu locally, but in a different location. To use a local
   build of Kudu, set KUDU_BUILD_DIR to the path Kudu was built in and
   set KUDU_CLIENT_DIR to the path KUDU was installed in.
   Example:
     git clone https://github.com/cloudera/kudu.git
     ...build 3rd party etc...
     mkdir -p $KUDU_BUILD_DIR
     cd $KUDU_BUILD_DIR
     cmake <path to Kudu source dir>
     make
     DESTDIR=$KUDU_CLIENT_DIR make install
4) Look for Kudu in the toolchain if not using a local Kudu build.
5) Add Kudu service startup scripts. The Kudu in the toolchain is
   actually a parcel that has been renamed (the contents were not
   modified in any way), that mean the Kudu service binaries are there.
   Those binaries are now used to run the Kudu service.

Change-Id: I3db88cbd27f2ea2394f011bc8d1face37411ed58
---
M CMakeLists.txt
M be/CMakeLists.txt
M be/src/exec/CMakeLists.txt
M be/src/exec/kudu-scan-node-test.cc
M be/src/exec/kudu-scan-node.cc
M be/src/exec/kudu-scan-node.h
M be/src/exec/kudu-scanner.cc
M be/src/exec/kudu-table-sink-test.cc
M be/src/exec/kudu-table-sink.cc
M be/src/exec/kudu-table-sink.h
M be/src/exec/kudu-util.cc
M be/src/exec/kudu-util.h
M be/src/runtime/coordinator.cc
M bin/bootstrap_toolchain.py
M bin/clean.sh
M bin/impala-config.sh
M common/thrift/generate_error_codes.py
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeModifyStmtsTest.java
M fe/src/test/java/com/cloudera/impala/analysis/ParserTest.java
M fe/src/test/java/com/cloudera/impala/analysis/ToSqlTest.java
M fe/src/test/java/com/cloudera/impala/planner/KuduPlannerTest.java
M fe/src/test/java/com/cloudera/impala/testutil/TestUtils.java
M testdata/bin/kill-all.sh
M testdata/bin/run-all.sh
D testdata/bin/run-kudu.sh
D testdata/bin/stop-kudu.sh
M testdata/cluster/admin
A testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common
A testdata/cluster/node_templates/cdh5/etc/init.d/kudu-master
A testdata/cluster/node_templates/cdh5/etc/init.d/kudu-tserver
A testdata/cluster/node_templates/cdh5/etc/kudu/master.conf.tmpl
A testdata/cluster/node_templates/cdh5/etc/kudu/tserver.conf.tmpl
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
M tests/common/skip.py
M tests/common/test_dimensions.py
M tests/metadata/test_ddl.py
M tests/metadata/test_show_create_table.py
M tests/query_test/test_kudu.py
39 files changed, 350 insertions(+), 111 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/85/1985/6
-- 
To view, visit http://gerrit.cloudera.org:8080/1985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3db88cbd27f2ea2394f011bc8d1face37411ed58
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Adar Dembo <adar@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <david.alves@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>