Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 29D1A195C6 for ; Mon, 7 Mar 2016 23:45:42 +0000 (UTC) Received: (qmail 4072 invoked by uid 500); 7 Mar 2016 23:45:41 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 4032 invoked by uid 500); 7 Mar 2016 23:45:41 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 2970 invoked by uid 99); 7 Mar 2016 23:45:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Mar 2016 23:45:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C99031806BD for ; Mon, 7 Mar 2016 23:45:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id CTw2ggXLKW74 for ; Mon, 7 Mar 2016 23:45:39 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 58B585F5CC for ; Mon, 7 Mar 2016 23:45:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u27Nja3E023800; Mon, 7 Mar 2016 23:45:36 GMT Message-Id: <201603072345.u27Nja3E023800@ip-10-146-233-104.ec2.internal> Date: Mon, 7 Mar 2016 23:45:36 +0000 From: "Skye Wanderman-Milne (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht , Marcel Kornacker , Alex Behm Reply-To: skye@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Reduce_size_of_cross-compiled_IR=0A?= X-Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5da643ab327f1c75cf775a6f870f38be3a3ed007 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Skye Wanderman-Milne has posted comments on this change. Change subject: Reduce size of cross-compiled IR ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2464/2/be/src/exec/hash-table.h File be/src/exec/hash-table.h: Line 131: int IR_ALWAYS_INLINE level() const { return level_; } > Done. It's a little confusing in this file since some things should be IR_A Yea, I think it's least confusing if you use IR_ALWAYS_INLINE in the cases where it's necessary for codegen and ALWAYS_INLINE when it's good for perf. -- To view, visit http://gerrit.cloudera.org:8080/2464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes