Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8674419263 for ; Mon, 7 Mar 2016 22:35:09 +0000 (UTC) Received: (qmail 28566 invoked by uid 500); 7 Mar 2016 22:35:09 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 28521 invoked by uid 500); 7 Mar 2016 22:35:09 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 28510 invoked by uid 99); 7 Mar 2016 22:35:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Mar 2016 22:35:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C4072C6A47 for ; Mon, 7 Mar 2016 22:35:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lsfODYa94Xuq for ; Mon, 7 Mar 2016 22:35:06 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id EE04C5F2EF for ; Mon, 7 Mar 2016 22:35:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u27MZ4Vh021895; Mon, 7 Mar 2016 22:35:04 GMT Message-Id: <201603072235.u27MZ4Vh021895@ip-10-146-233-104.ec2.internal> Date: Mon, 7 Mar 2016 22:35:04 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht , Casey Ching Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3105:_rework_handling_of_tuple_buffer_sizing_in_RowBatch=0A?= X-Gerrit-Change-Id: Idfd9cd681875821c1c379d97586d3f4850aae622 X-Gerrit-ChangeURL: X-Gerrit-Commit: 60fba32fa238cb309fdad828808003afd9dfe81f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3105: rework handling of tuple buffer sizing in RowBatch ...................................................................... Patch Set 2: After looking at those functions and looking through the code again, I realise that several places may assume that the row batches have the capacity RuntimeState::batch_size(). I think I'm going to rethink the approach to make it a bit safer. -- To view, visit http://gerrit.cloudera.org:8080/2473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfd9cd681875821c1c379d97586d3f4850aae622 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No