Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0AD0D19F75 for ; Sat, 5 Mar 2016 00:18:44 +0000 (UTC) Received: (qmail 56205 invoked by uid 500); 5 Mar 2016 00:18:44 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 56186 invoked by uid 500); 5 Mar 2016 00:18:44 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 56170 invoked by uid 99); 5 Mar 2016 00:18:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Mar 2016 00:18:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 592A21A07AA for ; Sat, 5 Mar 2016 00:18:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Iz3PhSAQ7VQL for ; Sat, 5 Mar 2016 00:18:42 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 7BC535F572 for ; Sat, 5 Mar 2016 00:18:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u250IfGL022267; Sat, 5 Mar 2016 00:18:41 GMT Message-Id: <201603050018.u250IfGL022267@ip-10-146-233-104.ec2.internal> Date: Sat, 5 Mar 2016 00:18:41 +0000 From: "Alex Behm (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Reduce_size_of_cross-compiled_IR=0A?= X-Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4d6f0b30cb55308f9b693ee8042c28accf5148e1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Alex Behm has posted comments on this change. Change subject: Reduce size of cross-compiled IR ...................................................................... Patch Set 1: (1 comment) Looks reasonable to me. Are there more places that could benefit from the inline annotation or is this a complete set? If it's not yet complete, it would be good to track what has been done and where we could continue. http://gerrit.cloudera.org:8080/#/c/2464/1/be/src/codegen/CMakeLists.txt File be/src/codegen/CMakeLists.txt: Line 65: COMMAND ${LLVM_OPT_EXECUTABLE} ${LLVM_OPT_IR_FLAGS} < ${IR_SSE_TMP_OUTPUT_FILE} > ${IR_SSE_OUTPUT_FILE} long lines -- To view, visit http://gerrit.cloudera.org:8080/2464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-HasComments: Yes