Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201603042319.u24NJ4LA020383@ip-10-146-233-104.ec2.internal>
Date: Fri, 4 Mar 2016 23:19:04 +0000
From: "Henry Robinson (Code Review)" <gerrit@cloudera.org>
To: Bharath Vissapragada <bharathv@cloudera.com>, impala-cr@cloudera.com,
        dev@impala.incubator.apache.org
CC: Tim Armstrong <tarmstrong@cloudera.com>, Huaisi Xu <hxu@cloudera.com>
Reply-To: henry@cloudera.com
Subject: 
 =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3114:_Add_a_pause_monitor_for_impala_processes.=0A?=
In-Reply-To: 
 <gerrit.1456926130000.I04eca63c0c44fa8f1b78833080acdc2176372263@gerrit.cloudera.org>
References: 
 <gerrit.1456926130000.I04eca63c0c44fa8f1b78833080acdc2176372263@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.10-rc0

Henry Robinson has posted comments on this change.

Change subject: IMPALA-3114: Add a pause monitor for impala processes.
......................................................................


Patch Set 2:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/2405/2/be/src/common/init.cc
File be/src/common/init.cc:

Line 17: #include <boost/thread/thread.hpp>
please don't use boost::thread directly


http://gerrit.cloudera.org:8080/#/c/2405/2/be/src/util/pause-monitor.cc
File be/src/util/pause-monitor.cc:

Line 25:   monitor_thread_.reset(new boost::thread(&PauseMonitor::WorkLoop, this));
Please use our Thread API instead of boost::thread.


Line 30:   monitor_thread_->join();
Let's not join (or do any work) in the destructor. Why not just fail fast?


Line 34:   MonotonicStopWatch sw;
just use MonotonicMillis() to measure time, and avoid the problem of having to convert to NS.


Line 35:   uint64_t extra_sleep_time;
move this inside the loop


http://gerrit.cloudera.org:8080/#/c/2405/2/be/src/util/pause-monitor.h
File be/src/util/pause-monitor.h:

Line 28: class PauseMonitor {
I don't think you need a class for this. InitCommonRuntime() can start a thread running WorkLoop() directly.


Line 39: milli
milliseconds


Line 46: /// Runs as long as stop is set to false.
       :    bool stop;
I don't think you need this coordination. Why wouldn't the pause monitor just run forever?


-- 
To view, visit http://gerrit.cloudera.org:8080/2405
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04eca63c0c44fa8f1b78833080acdc2176372263
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes