Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53FF51805B for ; Thu, 3 Mar 2016 23:52:19 +0000 (UTC) Received: (qmail 81747 invoked by uid 500); 3 Mar 2016 23:52:19 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 81705 invoked by uid 500); 3 Mar 2016 23:52:19 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 81691 invoked by uid 99); 3 Mar 2016 23:52:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Mar 2016 23:52:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9AEF8C2676 for ; Thu, 3 Mar 2016 23:52:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SCk_jDRor6ha for ; Thu, 3 Mar 2016 23:52:17 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 3FDE85F3F1 for ; Thu, 3 Mar 2016 23:52:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u23NqFeV029188; Thu, 3 Mar 2016 23:52:15 GMT Message-Id: <201603032352.u23NqFeV029188@ip-10-146-233-104.ec2.internal> Date: Thu, 3 Mar 2016 23:52:15 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Matthew Jacobs , Dimitris Tsirogiannis Reply-To: tmarshall@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-2738_Hive/Impala_inconsistency_in_GRANT/REVOKE_syntax=0A?= X-Gerrit-Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b X-Gerrit-ChangeURL: X-Gerrit-Commit: 4782785e3e6b9138114b6245c752fd58e05e7cf4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/2296/3/fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java File fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java: Line 173: if (serverName_ == null) { > Also check if the specified server name is same as the one in the authz con Done http://gerrit.cloudera.org:8080/#/c/2296/3/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeAuthStmtsTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeAuthStmtsTest.java: Line 133: // To be consistent with Hive, we allow any server name to be specified. > Remove comment. Done http://gerrit.cloudera.org:8080/#/c/2296/3/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test: Line 78: grant all on server server2 to grant_revoke_test_ALL_SERVER > This test simply grants the privilege and checks if it has been registered. Done -- To view, visit http://gerrit.cloudera.org:8080/2296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes