Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A66B319771 for ; Tue, 1 Mar 2016 23:54:01 +0000 (UTC) Received: (qmail 88738 invoked by uid 500); 1 Mar 2016 23:54:01 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 88699 invoked by uid 500); 1 Mar 2016 23:54:01 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 88688 invoked by uid 99); 1 Mar 2016 23:54:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2016 23:54:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F3839C39B9 for ; Tue, 1 Mar 2016 23:54:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ptj4dI4Hnlhx for ; Tue, 1 Mar 2016 23:54:00 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A89445FBED for ; Tue, 1 Mar 2016 23:53:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u21Nrv0I017008; Tue, 1 Mar 2016 23:53:57 GMT Message-Id: <201603012353.u21Nrv0I017008@ip-10-146-233-104.ec2.internal> Date: Tue, 1 Mar 2016 23:53:57 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht , Sailesh Mukil , Matthew Jacobs Reply-To: tmarshall@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-1822:_Cleanup_query_profile_log=0A?= X-Gerrit-Change-Id: I52430d192d27cdf9bc0d81f26a63048eaeec5d29 X-Gerrit-ChangeURL: X-Gerrit-Commit: 985c156221d2d1b4665bc8d85e39ba1161676514 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1822: Cleanup query profile log ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2260/4/be/src/util/logging-support.cc File be/src/util/logging-support.cc: Line 109: DeleteOldLogs > nit: add path_pattern so we know which caller is affected Done -- To view, visit http://gerrit.cloudera.org:8080/2260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52430d192d27cdf9bc0d81f26a63048eaeec5d29 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes