Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 376B919523 for ; Tue, 1 Mar 2016 23:10:06 +0000 (UTC) Received: (qmail 54935 invoked by uid 500); 1 Mar 2016 23:10:06 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 54894 invoked by uid 500); 1 Mar 2016 23:10:06 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 54883 invoked by uid 99); 1 Mar 2016 23:10:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2016 23:10:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7AC11C0C94 for ; Tue, 1 Mar 2016 23:10:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id RlxRGbKUS-aj for ; Tue, 1 Mar 2016 23:10:04 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 9C81B5FE69 for ; Tue, 1 Mar 2016 23:10:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u21NA3wx014622; Tue, 1 Mar 2016 23:10:03 GMT Message-Id: <201603012310.u21NA3wx014622@ip-10-146-233-104.ec2.internal> Date: Tue, 1 Mar 2016 23:10:03 +0000 From: "Dan Hecht (Code Review)" To: Michael Ho , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3068:_Don't_call_exit(1)_on_fatal_errors.=0A?= X-Gerrit-Change-Id: I00a43a69512c07eb351cf13bd1353226719744ca X-Gerrit-ChangeURL: X-Gerrit-Commit: 939df95aa99e4ee6e7e85c1c77ddffd0f869bc54 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Dan Hecht has posted comments on this change. Change subject: IMPALA-3068: Don't call exit(1) on fatal errors. ...................................................................... Patch Set 1: Code-Review+2 How did you test this? If you haven't already, please force one of these paths to make sure things work as expected. Also, please have Skye take a look at the llvm change in case she's aware of some reason we weren't installing our own handler. -- To view, visit http://gerrit.cloudera.org:8080/2364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00a43a69512c07eb351cf13bd1353226719744ca Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho Gerrit-Reviewer: Dan Hecht Gerrit-HasComments: No