Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D142C18982 for ; Tue, 1 Mar 2016 01:24:21 +0000 (UTC) Received: (qmail 33418 invoked by uid 500); 1 Mar 2016 01:24:17 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 33323 invoked by uid 500); 1 Mar 2016 01:24:16 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 33312 invoked by uid 99); 1 Mar 2016 01:24:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2016 01:24:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 44686C0140 for ; Tue, 1 Mar 2016 01:24:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 0vvy7JeO3h7V for ; Tue, 1 Mar 2016 01:24:15 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 5C1C65F3DC for ; Tue, 1 Mar 2016 01:24:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u211OEKl025820; Tue, 1 Mar 2016 01:24:14 GMT Message-Id: <201603010124.u211OEKl025820@ip-10-146-233-104.ec2.internal> Date: Tue, 1 Mar 2016 01:24:14 +0000 From: "Marcel Kornacker (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-2.5.0=5F5.7.0)_IMPALA-3103:_More_efficient_Bloom_Filter_serialisation.=0A?= X-Gerrit-Change-Id: I5237e776a197cb2696675dbbe0359e751605ed84 X-Gerrit-ChangeURL: X-Gerrit-Commit: 88a2824d7becfd0b55fef58f5b0616f1298b9865 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3103: More efficient Bloom Filter serialisation. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2359/1/be/src/util/bloom-filter.cc File be/src/util/bloom-filter.cc: Line 65: DCHECK_EQ(thrift.directory.size(), 1ll << (log_num_buckets_ + LOG_BUCKET_BYTE_SIZE)); 1ll << .. shows up frequently, create a helper function in .h Line 82: thrift->directory.resize(1ll << (log_num_buckets_ + LOG_BUCKET_BYTE_SIZE)); string dir_string(static_cast(directory_), ...); dir_string.swap(thrift->directory); ? -- To view, visit http://gerrit.cloudera.org:8080/2359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5237e776a197cb2696675dbbe0359e751605ed84 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: Yes