impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly not really pseudo-random.
Date Tue, 08 Mar 2016 02:24:38 GMT
Hello Internal Jenkins, Silvius Rus,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2476

to review the following change.

Change subject: IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly
not really pseudo-random.
......................................................................

IMPALA-2599: Pseudo-random sleep before acquiring kerberos ticket possibly not really pseudo-random.

A pseudo-random number generator was used to add a sleep before
acquiring a kerberos ticket so that there is minimal traffic to the
KDC. This generator was not seeded which resulted in every impalad
waking up at the same time to contact the KDC for a ticket.

This change seeds the generator with a std::random_device so that
different impalads have different sleep times.

Change-Id: I727a1b68aca43546bb79603b0ca83163ee169aa9
Reviewed-on: http://gerrit.cloudera.org:8080/2429
Reviewed-by: Sailesh Mukil <sailesh@cloudera.com>
Reviewed-by: Silvius Rus <srus@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/rpc/authentication.cc
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/76/2476/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I727a1b68aca43546bb79603b0ca83163ee169aa9
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Silvius Rus <srus@cloudera.com>

Mime
View raw message