impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3139: Fix drop table statement to not drop views and vice versa
Date Fri, 04 Mar 2016 15:04:33 GMT
Bharath Vissapragada has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2458

Change subject: IMPALA-3139: Fix drop table statement to not drop views and vice versa
......................................................................

IMPALA-3139: Fix drop table statement to not drop views and vice versa

This commit fixes the following two issues

- A drop table statement can drop a view with same name when "IF EXISTS" is specified.
- A drop view statement can drop a table with same name when "IF EXISTS" is specified.

This happens due to lack of checks in the Catalog before the drop executes.

Change-Id: I0d35cd1f50d9b8d50223660f753c56529cbbc311
---
M common/thrift/JniCatalog.thrift
M fe/src/main/java/com/cloudera/impala/analysis/DropTableOrViewStmt.java
M fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
M testdata/workloads/functional-query/queries/QueryTest/views-ddl.test
4 files changed, 38 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/58/2458/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2458
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d35cd1f50d9b8d50223660f753c56529cbbc311
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>

Mime
View raw message