impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-3068: Don't call exit(1) on fatal errors.
Date Tue, 01 Mar 2016 01:49:06 GMT
Michael Ho has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2362

Change subject: IMPALA-3068: Don't call exit(1) on fatal errors.
......................................................................

IMPALA-3068: Don't call exit(1) on fatal errors.

When hitting certain fatal errors, Impalad may call EXIT_WITH_ERROR()
to exit Impalad. While there are error messages logged, they may not
have been flushed to the log file before exit occurs. This change
converts multiple places in the code which call exit(1) to use
LOG(FATAL) so we will ensure all logs are flushed before abort()
is invoked.

This change also installs a "fatal error handler" for LLVM. It's
invoked right before LLVM calls exit(1) when it hits a fatal error.

Change-Id: I64072c413d50f9a84232406c1f2526b8072c64f6
---
M be/src/codegen/llvm-codegen.cc
M be/src/common/status.h
M be/src/scheduling/request-pool-service.cc
M be/src/service/impala-server.cc
M be/src/util/jni-util.h
5 files changed, 24 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/62/2362/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I64072c413d50f9a84232406c1f2526b8072c64f6
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Michael Ho <kwho@cloudera.com>

Mime
View raw message