impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-1756: Constant expressions not checked for errors, no state cleanup on exception.
Date Tue, 01 Mar 2016 00:15:50 GMT
Hello Internal Jenkins, Alex Behm,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2357

to review the following change.

Change subject: IMPALA-1756: Constant expressions not checked for errors, no state cleanup
on exception.
......................................................................

IMPALA-1756: Constant expressions not checked for errors, no state cleanup on exception.

Changed the way the function context error message is returned. Also, changed the
exception thrown in SingleNodePlanner from IllegalStateException to AnalysisException
in case of an exception in registerConjuncts().

This commit follows from:

https://github.com/cloudera/Impala/commit/d497ba6ceffaec2af6c76e99fe16b29e871140eb

This is a new commit since the previous one was closed before making these changes.

Dummy commit to make jenkins branch diff job result more accurate.

Change-Id: Ifa9b7c0884d76b6d7911d8cd80355a8ba13c4c18
Reviewed-on: http://gerrit.cloudera.org:8080/560
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 059ee4e4d79569e411d63328550731cb19163351)
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/57/2357/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa9b7c0884d76b6d7911d8cd80355a8ba13c4c18
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.2.0_5.4.x
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message