impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost
Date Thu, 31 Mar 2016 16:46:19 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-2805: Order filters based on selectivity and cost
......................................................................


Patch Set 2:

(11 comments)

http://gerrit.cloudera.org:8080/#/c/2598/2/fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java
File fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java:

Line 356:           if (thenCost > maxThenCost) {
> single line
Done


Line 363:       for (int i = 0; i < children_.size(); ++i) {
> both sides of the if are almost identical, combine them
Done


http://gerrit.cloudera.org:8080/#/c/2598/2/fe/src/main/java/com/cloudera/impala/analysis/Expr.java
File fe/src/main/java/com/cloudera/impala/analysis/Expr.java:

Line 84:   public final static int VAR_LEN_BINARY_PREDICATE_COST = 5;
> group with binary_predicate_cost
Done


http://gerrit.cloudera.org:8080/#/c/2598/2/fe/src/main/java/com/cloudera/impala/planner/EmptySetNode.java
File fe/src/main/java/com/cloudera/impala/planner/EmptySetNode.java:

Line 56:     conjuncts_ = orderConjuncts(conjuncts_);
> remove; this has no effect (this node always produces an empty set)
Done


http://gerrit.cloudera.org:8080/#/c/2598/2/fe/src/main/java/com/cloudera/impala/planner/HBaseScanNode.java
File fe/src/main/java/com/cloudera/impala/planner/HBaseScanNode.java:

Line 131: 
> avoid single-statement groups/double-spacing.
Done


http://gerrit.cloudera.org:8080/#/c/2598/2/fe/src/main/java/com/cloudera/impala/planner/HashJoinNode.java
File fe/src/main/java/com/cloudera/impala/planner/HashJoinNode.java:

Line 100: 
> remove blank line or move; these 3 lines belong together.
Done


http://gerrit.cloudera.org:8080/#/c/2598/2/fe/src/main/java/com/cloudera/impala/planner/PlanNode.java
File fe/src/main/java/com/cloudera/impala/planner/PlanNode.java:

Line 639:   public static <T extends Expr> List<T> orderConjuncts(List<T>
conjuncts) {
> let's stick that in Expr.java
Done


Line 643:     List<T> hasSelectivity = new ArrayList<T>();
> withSelectivity?
Done


Line 659:       T smallestConjunct =  null;
> optConjunct?
Done


Line 679:         @Override
> remove override
Done


Line 684: 
> remove gratuitous blank lines, like this one
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2598
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02279a26fbc6308ac5eb819d78345fc010469034
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message