impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option
Date Wed, 30 Mar 2016 22:58:56 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option
......................................................................


Patch Set 8: Code-Review+2

(4 comments)

Please see if Matt wanted to make another pass before committing.

http://gerrit.cloudera.org:8080/#/c/2384/8/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 2056: ordinal
position


Line 2061: ordinal
position (just so we have a consistent terminology).


http://gerrit.cloudera.org:8080/#/c/2384/8/testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test
File testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test:

Line 203: ---- QUERY
the comments for the other queries were helpful. how about one here.


Line 213: ---- QUERY
and here, to explain what is being tested.


-- 
To view, visit http://gerrit.cloudera.org:8080/2384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0c715ea23792b2a6872610839a40532aabbb5a6
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Silvius Rus <srus@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message