impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Fix start-impala-cluster.py with -s 0.
Date Wed, 30 Mar 2016 19:20:00 GMT
Henry Robinson has posted comments on this change.

Change subject: Fix start-impala-cluster.py with -s 0.
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2666/2/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:

Line 216: Return to avoid division by zero below.
sorry to be a pedant, but really we're returning because there's no work to be done (this
line should make sense no matter what logic the below block has). Don't have to change it
though.


-- 
To view, visit http://gerrit.cloudera.org:8080/2666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9abe40de6c6caea26b6faa03b7495f25cb07e0ac
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message