impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Re-enable Kudu in build using client stubs when needed
Date Wed, 30 Mar 2016 16:06:34 GMT
Todd Lipcon has posted comments on this change.

Change subject: Re-enable Kudu in build using client stubs when needed
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2585/8/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

Line 259:             time.sleep(wait_secs_between_stmts)
> The writes arent always immediately visible.
Right, the issue is that in order to guarantee visibility of your own writes, you need Impala
to be configured with a consistency mode that only allows reading from the tablet leader,
which inhibits locality. The other option is for Impala to propagate timestamps from previous
writes to the next read, which would be somewhat tricky (we'd have to somehow get it from
the backend back up to the user's session in order to include it in the next query). I can
think of a couple other tricks we could play (eg introduce a 'sync' call which could be made
at the end of every write that waits for propagation) but should probably be deferred from
here.

Another easy workaround for the purposes of tests is to create the Impala tables with a single
replica, but then we aren't testing the replica selection code as well.

Either way, I agree that sleeping is somewhat fragile.


-- 
To view, visit http://gerrit.cloudera.org:8080/2585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message