impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] fix broken bzip2 executable symlinks and make them relative and relocatable
Date Wed, 30 Mar 2016 00:32:13 GMT
Hello Casey Ching,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2525

to look at the new patch set (#2).

Change subject: fix broken bzip2 executable symlinks and make them relative and relocatable
......................................................................

fix broken bzip2 executable symlinks and make them relative and relocatable

The following bzip2 package artifacts are broken symlinks that only resolve on
the Cloudera machine that builds the toolchain:

  bzless
  bzfgrep
  bzegrep
  bzcmp

For example, if you're using the toolchain, you might find a symlink
similar to:

$ file bzip2-1.0.6-p1/bin/bzless
bzip2-1.0.6-p1/bin/bzless: broken symbolic link to /data/jenkins/bzip2-1.0.6-p1/bin/bzmore
$

bzip2 is being built per its directions, but the symlinks generated here
aren't relocatable, as demonstrated above.  Since these symlinks need to
point to targets in the same directory, one simple fix is to make the
symlinks relative, not absolute:

lrwxrwxrwx 1 mikeb mikeb 6 Mar  9 16:32 bzless -> bzmore

This is a pretty typical convention.

Testing:

Both `./build.sh bzip2 1.0.6-p2` and `./buildall.sh` succeeded. The
symlinks are relative:

$ ls -l build/bzip2-1.0.6-p2/bin/{bzless,bz?grep,bzcmp}
lrwxrwxrwx 1 mikeb mikeb 6 Mar 10 09:45 build/bzip2-1.0.6-p2/bin/bzcmp -> bzdiff
lrwxrwxrwx 1 mikeb mikeb 6 Mar 10 09:45 build/bzip2-1.0.6-p2/bin/bzegrep -> bzgrep
lrwxrwxrwx 1 mikeb mikeb 6 Mar 10 09:45 build/bzip2-1.0.6-p2/bin/bzfgrep -> bzgrep
lrwxrwxrwx 1 mikeb mikeb 6 Mar 10 09:45 build/bzip2-1.0.6-p2/bin/bzless -> bzmore
$

As a last test, I successfully built Impala using bzip-1.0.6-p2 (copied
into $IMPALA_TOOLCHAIN, not via s3).

Change-Id: Ic779d09805be2956491b7cfbb49c3d5ada300ec3
---
M buildall.sh
A source/bzip2/bzip2-1.0.6-patches/002-directoryless-executable-symlinks.diff
2 files changed, 22 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/25/2525/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic779d09805be2956491b7cfbb49c3d5ada300ec3
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message